Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39683 )
Change subject: soc/intel/tigerlake: Configure Hyperthreading
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39683/6/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39683/6/src/soc/intel/tigerlake/rom...
PS6, Line 147: config->HyperThreadingDisable ? 0 : 1
Current code also resolve the case which user provides non 0 or 1. […]
same for !val:
#include <stdio.h>
#define val(A) "!" #A " = %d\n", !A
void main() {
printf(val(0));
printf(val(1));
printf(val(2));
printf(val(-1));
}
!0 = 1
!1 = 0
!2 = 0
!-1 = 0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc94e6b8ecd59a43be60bf60dc7dd0811ac0350b
Gerrit-Change-Number: 39683
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Mar 2020 09:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment