build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )
Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... PS6, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... PS6, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... PS6, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); please, no spaces at the start of a line