Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45220 )
Change subject: xeon_sp/skx: Reorder pci_devs.h
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45220/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45220/2//COMMIT_MSG@11
PS2, Line 11:
It would be nice to check if TiogaPass remains identical with BUILD_TIMELESS=1
https://review.coreboot.org/c/coreboot/+/45220/2/src/soc/intel/xeon_sp/cpx/i...
File src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/45220/2/src/soc/intel/xeon_sp/cpx/i...
PS2, Line 106: #define IIO_CBDMA_MMIO_ALIGNMENT 14 //2^14 - 16kB
I don't think you meant to add this line in this commit?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I939707cc9e58e23f053156f40df4c21a6072570b
Gerrit-Change-Number: 45220
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Sep 2020 09:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment