Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38268 )
Change subject: intel/{gm45,x4x},i82801{ix|jx}: Move enable_smbus() call
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38268/3/src/northbridge/intel/x4x/r...
File src/northbridge/intel/x4x/romstage.c:
https://review.coreboot.org/c/coreboot/+/38268/3/src/northbridge/intel/x4x/r...
PS3, Line 37: enable_smbus();
you might want to swap the order of this patch with the one implementing this on i82801gx to make sure x4x is not broken on this patch when coupled with i82801gx.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc7631abb550b31af722ccf3b69afdc01fdb616e
Gerrit-Change-Number: 38268
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Jan 2020 13:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment