Attention is currently required from: Felix Singer, Raul Rangel, Tim Wawrzynczak.
Ahamed Husni has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 )
Change subject: drivers/smbus: initialize SC16IS7XX I2C to UART converter chip
......................................................................
Patch Set 9:
(1 comment)
File src/drivers/smbus/i2c_smbus_console.c:
https://review.coreboot.org/c/coreboot/+/67342/comment/0246b5d0_3e2847a7
PS6, Line 10: #if (CONFIG(CONSOLE_I2C_SMBUS) && (ENV_ROMSTAGE || ENV_BOOTBLOCK))
: early_pch_init();
: #endif
: #if (CONFIG(SC16IS750_INIT) && (ENV_ROMSTAGE || ENV_BOOTBLOCK))
: sc16is750_init();
: #endif
I think you could refactor this like […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib31188b8c0f9b0ce9454da984e630eca9101d145
Gerrit-Change-Number: 67342
Gerrit-PatchSet: 9
Gerrit-Owner: Ahamed Husni
ahamedhusni73@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sun, 11 Sep 2022 12:03:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment