7 Jun
2021
7 Jun
'21
10:58 a.m.
Attention is currently required from: Tristan Corrick, Arthur Heymans, Iru Cai (vimacs). Máté Kukri (mkukri) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform ......................................................................
Patch Set 29:
(1 comment)
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/2c08008b_b4e6ba62 PS29, Line 524: const struct usb2_port_config mainboard_usb2_ports[MAX_USB2_PORTS] = { Shouldn't we check if the USB2 ports are actually routed to EHCI or xHCI before reading these values?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f6e8c97b5122101de2f36bba8ba9f8ddd5b813a
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 29
Gerrit-Owner: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Maslowski info@orangecms.org
Gerrit-Reviewer: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Jamal Wright Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Pablo Stebler pablo@stebler.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska github@slrie.de
Gerrit-CC: Máté Kukri (mkukri) kukri.mate@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Tristan Corrick tristan@corrick.kiwi
Gerrit-Attention: Tristan Corrick tristan@corrick.kiwi
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Comment-Date: Mon, 07 Jun 2021 08:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment