Attention is currently required from: Nico Huber, Peter Lemenkov, Angel Pons, Alexander Couzens, Patrick Rudolph.
amersel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
Patch Set 16:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52659/comment/e718e5ab_89a7180e
PS14, Line 28: when IFD is unlocked
Internal flashing can also be done with a locked IFD, but not all regions are readable/writable.
I haven't attempted internal flashing with a locked IFD so I'll leave that as untested for now. However, I assume it's possible to flash only the bios portion in coreboot when IFD is locked.
File src/mainboard/lenovo/w541/smihandler.c:
https://review.coreboot.org/c/coreboot/+/52659/comment/087aa35c_967e1a7a
PS14, Line 13: #define GPE_EC_WAKE 13
Seems to be correct.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 16
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Jun 2021 14:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment