Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37516 )
Change subject: mb/facebook/monolith: Add Facebook Monolith ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37516/5/Documentation/mainboard/fac... File Documentation/mainboard/facebook/monolith.md:
https://review.coreboot.org/c/coreboot/+/37516/5/Documentation/mainboard/fac... PS5, Line 24: The system has an external flash chip which is a 16 MiB soldered SOIC-8 chip.
The external part only refers to programming using an external programmer. […]
Done
https://review.coreboot.org/c/coreboot/+/37516/5/Documentation/mainboard/fac... PS5, Line 33: - hardware monitor
I'd prefer if all the elements of the list started with a capital letter
Done
https://review.coreboot.org/c/coreboot/+/37516/5/Documentation/mainboard/fac... PS5, Line 43: graphics
With what? Tianocore, FSP GOP?
Done
https://review.coreboot.org/c/coreboot/+/37516/5/Documentation/mainboard/fac... PS5, Line 50:
Trailing space
Done
https://review.coreboot.org/c/coreboot/+/37516/5/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/37516/5/src/mainboard/facebook/mono... PS5, Line 25:
Why three spaces?
Done