Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/3467 )
Change subject: libpayload: usb: Deep search for endpoint descriptors ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/3467/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/3467/1//COMMIT_MSG@9 PS1, Line 9: This improving searching for endpoint descriptors This improv*es* …
https://review.coreboot.org/c/coreboot/+/3467/1//COMMIT_MSG@10 PS1, Line 10: and skipping non-endpoint interface descriptors. skipping → skips?
Do these have ID 4?
https://review.coreboot.org/c/coreboot/+/3467/1/payloads/libpayload/drivers/... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/3467/1/payloads/libpayload/drivers/... PS1, Line 395: while ((endp->bDescriptorType != 0x05) && (endp->bDescriptorType != 0x04) && (endp->bLength !=0)) { Add spaces around the `!=`.
https://review.coreboot.org/c/coreboot/+/3467/1/payloads/libpayload/drivers/... PS1, Line 396: endp = (endpoint_descriptor_t *)((char *)endp + endp->bLength); Trailing whitespace.
Did you run `make gitconfig`?