Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41065 )
Change subject: treewide: Move "is part of the coreboot project" line in its own comment
......................................................................
Patch Set 1:
Patch Set 1:
I feel like two comments right above each other looks kinda ugly. I also don't think we'll be able to maintain it unless you put in a linter check for it.
I think we already have four different ways of doing it in the tree: every combination of one or two comments, spdx first or second.
Do we even need that "part of the coreboot project" line? Does anyone care about that being there? For all I care, I'd be fine with just taking it out completely...
I think it's needed so that if one of our files ends up being used somewhere else, people have a change to look up its history, authors/copyright etc.
(Also, I think ideally the SPDX identifier is supposed to be the first line, so if anything we might want to move all the coreboot project lines below that.)
My motivation for pushing now is to get the SPDX transition done for the release. Can we leave the remaining lint work for later? :-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2280b19972e37c36d8c67a67e0320296567fa4f6
Gerrit-Change-Number: 41065
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 05 May 2020 21:08:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment