hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32057 )
Change subject: mediatek/mt8183: Calibrate vsim2 to 2.7 V
......................................................................
Patch Set 14: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32057/10/src/soc/mediatek/mt8183/mt6358.c
File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/#/c/32057/10/src/soc/mediatek/mt8183/mt6358.c@74...
PS10, Line 745: vsim2_cali_0mv = (vsim2_cali_0mv > 6) ? (vsim2_cali_0mv - 6) : 0;
nit: I think writing this as […]
Hi Julius,
After checking the calibration register with our chip designer, I have a misunderstanding about it. Please help review the patch again, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dffdde89cbde91286d92e6c2b445f0b3d0ad2fe
Gerrit-Change-Number: 32057
Gerrit-PatchSet: 14
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Jun 2019 13:17:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment