Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: soc/intel: Add Intel Xeon Scalable Processor support ......................................................................
Patch Set 44:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38548/44/src/soc/intel/xeon_sp/soc_... File src/soc/intel/xeon_sp/soc_util.c:
https://review.coreboot.org/c/coreboot/+/38548/44/src/soc/intel/xeon_sp/soc_... PS44, Line 375: 127 hm this can't be right. Why other bus numbers are power of two and below it is 1 less?
https://review.coreboot.org/c/coreboot/+/38548/44/src/soc/intel/xeon_sp/soc_... PS44, Line 361: switch (maxbusno) { : case 0: : printk(BIOS_DEBUG, "Max Bus Number 2048 (2GB MMCFG Range)\n"); : break; : case 1: : printk(BIOS_DEBUG, "Max Bus Number 1048 (1GB MMCFG range)\n"); : break; : case 2: : printk(BIOS_DEBUG, "Max Bus Number 512 (512MB MMCFG range)\n"); : break; : case 4: : printk(BIOS_DEBUG, "Max Bus Number 256 (256MB MMCFG range)\n"); : break; : case 5: : printk(BIOS_DEBUG, "Max Bus Number 127 (128MB MMCFG range)\n"); : break; : case 6: : printk(BIOS_DEBUG, "Max Bus Number 63 (64MB MMCFG range)\n"); : break; : default: : printk(BIOS_DEBUG, "Invalid Max Bus Number 0x%x\n", maxbusno); : break; : } up to you, but this switch statement can be colapsed into:
printk(BIOS_DEBUG, "Max bus number %u (%u MB MMCFG Range)\n", (1 << (11 - maxbusno)) - 1, (1 << (11 - maxbusno)));