27 Nov
2019
27 Nov
'19
6:32 a.m.
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37210 )
Change subject: soc/amd/common: Remove guards on ACPIMMIO utils ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
On the basis that AMD won't deprecate ACPIMMIO...
https://review.coreboot.org/c/coreboot/+/37210/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/gpio_banks.h:
https://review.coreboot.org/c/coreboot/+/37210/1/src/soc/amd/common/block/in... PS1, Line 21: acpimmio_map
Split the patch to get a reproducible build of google/aleena.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/37210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c1f0c9c9a6711532c5078c08cdf9e6612f3bc9c
Gerrit-Change-Number: 37210
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 14:32:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment