Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35073 )
Change subject: drivers/generic: Add new driver for power resource pseudo-device ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35073/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35073/4//COMMIT_MSG@36 PS4, Line 36: PowerResource (PR00, 0, 0)
Done
Was this done in both ACPI and devicetree? Looking at the CLs following this, I think it is organized very differently in coreboot and in ACPI:
ACPI --> Power resource associated with I2C peripheral. Lives under the peripheral device in ACPI hierarchy.
Devicetree in coreboot --> Power resource is parent of the I2C peripheral.
I think we should be consistent in both representations.
https://review.coreboot.org/c/coreboot/+/35073/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35073/6//COMMIT_MSG@52 PS6, Line 52: Can you also add example of what devicetree looked like before and what it would look like with this change?
https://review.coreboot.org/c/coreboot/+/35073/6/src/drivers/generic/power_r... File src/drivers/generic/power_resource/Kconfig:
https://review.coreboot.org/c/coreboot/+/35073/6/src/drivers/generic/power_r... PS6, Line 1: TODO TODO(twawrzynczak)
https://review.coreboot.org/c/coreboot/+/35073/6/src/drivers/generic/power_r... File src/drivers/generic/power_resource/power_resource.c:
https://review.coreboot.org/c/coreboot/+/35073/6/src/drivers/generic/power_r... PS6, Line 66: /* .acpi_fill_ssdt_generator = power_resource_fill_ssdt,*/ Get rid of commented code?