Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47667 )
Change subject: mb/google/volteer/var/voema: Update gpio and devicetree settings
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47667/6/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/voema/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47667/6/src/mainboard/google/voltee...
PS6, Line 7: ramstage-y += gpio.c
nit: alpabetic sync bootblock - ramstage - romstage
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I719a9948ed0d60e1de5368e096ff60c2345803b0
Gerrit-Change-Number: 47667
Gerrit-PatchSet: 6
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 10:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment