Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@26 PS3, Line 26: - The Fn key is on by default
Yes 62/66 is safe to use. […]
From the cbmem log I can see the EC firmware ID and version are read correctly, but I don't know what's the proper way to change the code now. I may change it in the future.
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@27 PS3, Line 27: - Mainboard serial number is invalid
Starting with the x240/t440 the at24 is no more, it's integrated into the EC
Still don't know how to read these information. Maybe I should find a way to unselect SMBIOS_PROVIDED_BY_MOBO until it's solved?
https://review.coreboot.org/c/coreboot/+/34359/3/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34359/3/src/mainboard/lenovo/t440p/... PS3, Line 1: chip northbridge/intel/haswell # FIXME: check gfx.ndid and gfx.did
remove FIXME
Done