Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34748 )
Change subject: amd/stoneyridge: Unify SMM relocation
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34748/3/src/soc/amd/stoneyridge/cpu...
File src/soc/amd/stoneyridge/cpu.c:
https://review.coreboot.org/c/coreboot/+/34748/3/src/soc/amd/stoneyridge/cpu...
PS3, Line 69: params->tseg_base.lo = ALIGN_DOWN(tseg_base, 128 * KiB);
I don't like the impression here that tseg_base programmed to SMMR could potentially be different fr […]
Done
https://review.coreboot.org/c/coreboot/+/34748/3/src/soc/amd/stoneyridge/cpu...
PS3, Line 80: Setting up SMI for CPU
That's the verbatim text accepted/used for late soc/intel. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34748
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02ad07e049cb74ccb52ba3d41eb16c58a2cfb38b
Gerrit-Change-Number: 34748
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Aug 2019 14:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment