Attention is currently required from: Elyes Haouas, Felix Singer, Jakub "Kuba" Czapiga, Julius Werner, Martin L Roth.
Maximilian Brune has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86012?usp=email )
Change subject: tree: Switch to C23
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
should we revert commit 84347d0b4598 and commit 7bcec7a2efc4 ?
We can't revert it unless we find a solution to the problem. I agree that it is not the optimal solution, but I didn't have time to figure out how to compile our coreboot toolchain to make it work with linux as well as coreboot. And to be quite honest I also didn't want to. I don't think we should change our toolchain just because one of our payloads needs to be built somehow special. But if you ask me this is just a side effect of another problem:
I personally don't think coreboot should be distributor for payloads (I don't think that is gonna change though). The maintenance effort is just not worth it. That is also the reason why many of our payloads don't work for most platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86012?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4b2184e5c57143b11e3cc433d09d74a83028420
Gerrit-Change-Number: 86012
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 05 Feb 2025 16:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr