Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38698 )
Change subject: vc/amd/fsp/picasso: Add PCIe and DDI helpers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38698/1/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/38698/1/src/vendorcode/amd/fsp/pica... PS1, Line 131: unsigned int
Ew, yeah I agree.
i think unsigend int was used here, since this are bitfields and not full uint32_t.
sadly the memory layout of bitfield strucs is undefined behavior in c; since this will always be compiled for a little endian architecture, this should still work in practice. the compiler can basically choose if it fills the bitfields in the dwords from top or bottom