Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19988 )
Change subject: cpu/amd/car: Fix checkpatch warnings ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/19988/1/src/cpu/amd/car/disable_cache_as_ram... File src/cpu/amd/car/disable_cache_as_ram.c:
PS1, Line 61: msr.lo &= ~(SYSCFG_MSR_MtrrFixDramEn : | SYSCFG_MSR_MtrrFixDramModEn); too bad this doesn't fit in one line
https://review.coreboot.org/#/c/19988/1/src/cpu/amd/car/post_cache_as_ram.c File src/cpu/amd/car/post_cache_as_ram.c:
PS1, Line 51: what about those spaces between type cast and value?
PS1, Line 51: here too
PS1, Line 67: until here