Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46033 )
Change subject: drivers/wifi: Drop maxsleep parameter from chip config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/intel/wifi/wifi...
File src/drivers/intel/wifi/wifi.c:
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/intel/wifi/wifi...
PS1, Line 54: By default, all intel wifi chips wake from S3
What about CNVi? I just checked the vendor ACPI of clevo/l140cu, where this is 0x04. […]
SLP_TYP_S3 is 5 for Intel hardware. I don't think 4 is a valid value. Even for CNVi, this should still be 5 i.e. SLP_TYP_S3. That is what the boards in coreboot currently use. So, this change does not really change the logic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42131fced008da0d51f0f777b7f2d99deaf68827
Gerrit-Change-Number: 46033
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 22:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment