Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35313 )
Change subject: src/northbridge/amd/pi/00730F01/northbridge.c: enable ACS and AER for PCIe ports
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35313/2/src/northbridge/amd/pi/0073...
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/35313/2/src/northbridge/amd/pi/0073...
PS2, Line 781: 0xB0
E or B?
0xE0 is an index register that provides access to GPP link core registers 0x0140XXXX and IO Link Strap Control register has an offset of 00B0 which assembles to 0x014000B0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a8eff0ba37196692f9db6519e498fe535ecd15
Gerrit-Change-Number: 35313
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 30 Dec 2019 16:33:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment