HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45123/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45123/3//COMMIT_MSG@10
PS3, Line 10:
tio should be to I guess. […]
Thx
https://review.coreboot.org/c/coreboot/+/45123/3/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/45123/3/src/arch/x86/smbios.c@493
PS3, Line 493: if (CONFIG_MAINBOARD_FAMILY != "")
wrong and not needed as 'smbios_add_string' will return "0" if empty (SMBIOS sepc - 6.1. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If007988496c972185bad097535c5fd30ccfcd45b
Gerrit-Change-Number: 45123
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Sep 2020 07:59:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment