build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine : Provide initial mainboard support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45206/7/payloads/libpayload/drivers...
File payloads/libpayload/drivers/serial/sc7280.c:
https://review.coreboot.org/c/coreboot/+/45206/7/payloads/libpayload/drivers...
PS7, Line 5: /* For simplicity sake let's rely on coreboot initalizing the UART. */
'initalizing' may be misspelled - perhaps 'initializing'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I428cf1a461ee63215f5683abbfed90202d1b2a88
Gerrit-Change-Number: 45206
Gerrit-PatchSet: 7
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 17:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment