Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45911 )
Change subject: drivers/i2c: Add chip driver for GPIO based I2C multiplexer
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45911/6/src/drivers/i2c/gpiomux/mux...
File src/drivers/i2c/gpiomux/mux/mux.c:
https://review.coreboot.org/c/coreboot/+/45911/6/src/drivers/i2c/gpiomux/mux...
PS6, Line 37: "_HID", ACPI_DT_NAMESPACE_HID)
Wait but if you do this and use PRP0001, aren't you deferring into the DT world entirely, including its bindings? We're not following the DT-based bindings exactly (around i2c-parent). Don't we need an ACPI-based _HID so we can say "this is the ACPI version"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib371108cc6043c133681066bf7bf4b2e00771e8b
Gerrit-Change-Number: 45911
Gerrit-PatchSet: 6
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 08 Oct 2020 16:16:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment