Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/#/c/29470/15/src/mainboard/portwell/m107/irqrout...
File src/mainboard/portwell/m107/irqroute.h:
https://review.coreboot.org/#/c/29470/15/src/mainboard/portwell/m107/irqrout...
PS15, Line 40: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses
Ack
https://review.coreboot.org/#/c/29470/15/src/mainboard/portwell/m107/irqrout...
PS15, Line 62: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 15
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 12 Jun 2019 10:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment
