Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48862 )
Change subject: drivers/intel/gma: Include gfx.asl by default for all platforms...
......................................................................
Patch Set 5: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/48862/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48862/5//COMMIT_MSG@7
PS5, Line 7: ...
:
: which
nit: maybe move the ... in front of "which select" - just my opinion :)
https://review.coreboot.org/c/coreboot/+/48862/5//COMMIT_MSG@15
PS5, Line 15: eg
e.g. Win...
https://review.coreboot.org/c/coreboot/+/48862/5/src/mainboard/51nb/x210/acp...
File src/mainboard/51nb/x210/acpi/graphics.asl:
https://review.coreboot.org/c/coreboot/+/48862/5/src/mainboard/51nb/x210/acp...
PS5, Line 5:
nit: drop that newline?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie71bd5fc7acd926b7ce7da17fbc108670fd453e0
Gerrit-Change-Number: 48862
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Dec 2020 20:16:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment