build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37401 )
Change subject: mb/*/*: use ACPIMMIO common block wherever possible ......................................................................
Patch Set 2:
(14 comments)
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/south_sta... File src/mainboard/amd/south_station/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/south_sta... PS2, Line 58: Data8 = pm_io_read8(0x27); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/south_sta... PS2, Line 59: Data16 = Data8 << 8; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/south_sta... PS2, Line 60: Data8 = pm_io_read8(0x26); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/south_sta... PS2, Line 138: Data8 = pm_io_read8(0x27); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/south_sta... PS2, Line 140: Data8 = pm_io_read8(0x26); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/union_sta... File src/mainboard/amd/union_station/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/union_sta... PS2, Line 59: Data8 = pm_io_read8(0x27); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/union_sta... PS2, Line 61: Data8 = pm_io_read8(0x26); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/union_sta... PS2, Line 138: Data8 = pm_io_read8(0x27); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/union_sta... PS2, Line 139: Data16 = Data8 << 8; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/amd/union_sta... PS2, Line 140: Data8 = pm_io_read8(0x26); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/asrock/e350m1... File src/mainboard/asrock/e350m1/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/asrock/e350m1... PS2, Line 56: Data8 = pm_io_read8(0x27); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/asrock/e350m1... PS2, Line 58: Data8 = pm_io_read8(0x26); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/biostar/am1ml... File src/mainboard/biostar/am1ml/romstage.c:
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/biostar/am1ml... PS2, Line 94: pm_io_write8(0x24 ,1); space prohibited before that ',' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/biostar/am1ml... PS2, Line 94: pm_io_write8(0x24 ,1); space required after that ',' (ctx:WxV)