HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45312 )
Change subject: src: include <device/pnp_def.h> only when needed ......................................................................
src: include <device/pnp_def.h> only when needed
Change-Id: I835e8786b84ec16889fd08f566328bc7a0a60c90 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/pnp_device.c M src/ec/hp/kbc1126/early_init.c M src/ec/kontron/it8516e/ec.c M src/include/device/pnp.h M src/mainboard/facebook/monolith/com_init.c M src/mainboard/lenovo/t400/dock.c M src/superio/aspeed/common/early_config.c M src/superio/fintek/common/early_serial.c M src/superio/fintek/f71808a/f71808a_hwm.c M src/superio/fintek/f71863fg/superio.c M src/superio/fintek/f71869ad/f71869ad_hwm.c M src/superio/fintek/f81866d/f81866d_hwm.c M src/superio/fintek/f81866d/f81866d_uart.c M src/superio/ite/common/early_serial.c M src/superio/ite/it8613e/superio.c M src/superio/ite/it8623e/superio.c M src/superio/ite/it8718f/superio.c M src/superio/ite/it8720f/superio.c M src/superio/ite/it8728f/superio.c M src/superio/ite/it8772f/superio.c M src/superio/ite/it8783ef/superio.c M src/superio/ite/it8786e/superio.c M src/superio/nuvoton/common/early_serial.c M src/superio/nuvoton/npcd378/superio.c M src/superio/serverengines/pilot/early_serial.c M src/superio/smsc/kbc1100/superio.c M src/superio/smsc/lpc47m10x/early_serial.c M src/superio/smsc/lpc47m15x/early_serial.c M src/superio/smsc/lpc47n217/superio.c M src/superio/smsc/lpc47n227/superio.c M src/superio/smsc/sch5545/sch5545_early_init.c M src/superio/smsc/sch5545/sch5545_emi.c M src/superio/smsc/sch5545/superio.c M src/superio/winbond/common/early_init.c M src/superio/winbond/w83627ehg/superio.c M src/superio/winbond/w83627hf/superio.c 36 files changed, 38 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/45312/1
diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index cd7adf3..1f5a8ee 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -5,6 +5,7 @@ #include <arch/io.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h>
/* PNP config mode wrappers */
diff --git a/src/ec/hp/kbc1126/early_init.c b/src/ec/hp/kbc1126/early_init.c index 415ebab..45a7c62 100644 --- a/src/ec/hp/kbc1126/early_init.c +++ b/src/ec/hp/kbc1126/early_init.c @@ -3,6 +3,8 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> + #include "ec.h"
void kbc1126_enter_conf(void) diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c index 9af670a..3ace04a 100644 --- a/src/ec/kontron/it8516e/ec.c +++ b/src/ec/kontron/it8516e/ec.c @@ -3,6 +3,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <ec/acpi/ec.h> #include <option.h>
diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h index 800bcc0..ffc5036 100644 --- a/src/include/device/pnp.h +++ b/src/include/device/pnp.h @@ -3,7 +3,6 @@
#include <stdint.h> #include <device/device.h> -#include <device/pnp_def.h> #include <device/pnp_type.h> #include <arch/io.h>
diff --git a/src/mainboard/facebook/monolith/com_init.c b/src/mainboard/facebook/monolith/com_init.c index 98a0232..f0c2157 100644 --- a/src/mainboard/facebook/monolith/com_init.c +++ b/src/mainboard/facebook/monolith/com_init.c @@ -3,6 +3,8 @@ #include <bootblock_common.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> + #include "onboard.h"
#define SERIAL_DEV1 PNP_DEV(ITE8528_CMD_PORT, 1) /* ITE8528 UART1 */ diff --git a/src/mainboard/lenovo/t400/dock.c b/src/mainboard/lenovo/t400/dock.c index b8163e71..043f3ac 100644 --- a/src/mainboard/lenovo/t400/dock.c +++ b/src/mainboard/lenovo/t400/dock.c @@ -6,6 +6,7 @@ #include <device/pnp_ops.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <delay.h> #include "dock.h" #include <superio/nsc/pc87382/pc87382.h> diff --git a/src/superio/aspeed/common/early_config.c b/src/superio/aspeed/common/early_config.c index b0aab89..716a896 100644 --- a/src/superio/aspeed/common/early_config.c +++ b/src/superio/aspeed/common/early_config.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <arch/io.h> -#include <device/pnp_def.h> #include <device/pnp_ops.h> #include <stdint.h> #include <commonlib/helpers.h> diff --git a/src/superio/fintek/common/early_serial.c b/src/superio/fintek/common/early_serial.c index 79af111..843e209 100644 --- a/src/superio/fintek/common/early_serial.c +++ b/src/superio/fintek/common/early_serial.c @@ -22,6 +22,7 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <stdint.h> #include "fintek.h"
diff --git a/src/superio/fintek/f71808a/f71808a_hwm.c b/src/superio/fintek/f71808a/f71808a_hwm.c index 340bc30..992a870 100644 --- a/src/superio/fintek/f71808a/f71808a_hwm.c +++ b/src/superio/fintek/f71808a/f71808a_hwm.c @@ -3,6 +3,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include "fintek_internal.h" #include "chip.h"
diff --git a/src/superio/fintek/f71863fg/superio.c b/src/superio/fintek/f71863fg/superio.c index c4e8dc9..11e1600 100644 --- a/src/superio/fintek/f71863fg/superio.c +++ b/src/superio/fintek/f71863fg/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <superio/conf_mode.h> #include <pc80/keyboard.h>
diff --git a/src/superio/fintek/f71869ad/f71869ad_hwm.c b/src/superio/fintek/f71869ad/f71869ad_hwm.c index 6333ae1..408e0e1 100644 --- a/src/superio/fintek/f71869ad/f71869ad_hwm.c +++ b/src/superio/fintek/f71869ad/f71869ad_hwm.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> + #include "chip.h" #include "fintek_internal.h"
diff --git a/src/superio/fintek/f81866d/f81866d_hwm.c b/src/superio/fintek/f81866d/f81866d_hwm.c index a7ed96b..41f9d47 100644 --- a/src/superio/fintek/f81866d/f81866d_hwm.c +++ b/src/superio/fintek/f81866d/f81866d_hwm.c @@ -7,6 +7,8 @@ #include <console/console.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> + #include "fintek_internal.h" #include "chip.h"
diff --git a/src/superio/fintek/f81866d/f81866d_uart.c b/src/superio/fintek/f81866d/f81866d_uart.c index 7d98a7f..23dda77 100644 --- a/src/superio/fintek/f81866d/f81866d_uart.c +++ b/src/superio/fintek/f81866d/f81866d_uart.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> + #include "fintek_internal.h" #include "f81866d.h"
diff --git a/src/superio/ite/common/early_serial.c b/src/superio/ite/common/early_serial.c index 6b05a38..b26680b 100644 --- a/src/superio/ite/common/early_serial.c +++ b/src/superio/ite/common/early_serial.c @@ -3,6 +3,7 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <stdint.h> #include "ite.h"
diff --git a/src/superio/ite/it8613e/superio.c b/src/superio/ite/it8613e/superio.c index 4d12457..83b1858 100644 --- a/src/superio/ite/it8613e/superio.c +++ b/src/superio/ite/it8613e/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <pc80/keyboard.h> #include <superio/conf_mode.h> #include <superio/ite/common/env_ctrl.h> diff --git a/src/superio/ite/it8623e/superio.c b/src/superio/ite/it8623e/superio.c index ca3455a..b7a4b49 100644 --- a/src/superio/ite/it8623e/superio.c +++ b/src/superio/ite/it8623e/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <pc80/keyboard.h> #include <superio/conf_mode.h> #include <superio/ite/common/env_ctrl.h> diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c index aab554f..47ecb27 100644 --- a/src/superio/ite/it8718f/superio.c +++ b/src/superio/ite/it8718f/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <pc80/keyboard.h> #include <superio/ite/common/env_ctrl.h> #include <superio/conf_mode.h> diff --git a/src/superio/ite/it8720f/superio.c b/src/superio/ite/it8720f/superio.c index c395953..dd399f8 100644 --- a/src/superio/ite/it8720f/superio.c +++ b/src/superio/ite/it8720f/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <pc80/keyboard.h> #include <option.h> #include <superio/ite/common/env_ctrl.h> diff --git a/src/superio/ite/it8728f/superio.c b/src/superio/ite/it8728f/superio.c index 22e6ecb..7943f13 100644 --- a/src/superio/ite/it8728f/superio.c +++ b/src/superio/ite/it8728f/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <superio/conf_mode.h> #include <pc80/keyboard.h> #include <superio/ite/common/env_ctrl.h> diff --git a/src/superio/ite/it8772f/superio.c b/src/superio/ite/it8772f/superio.c index 6672cdc..dc323ae 100644 --- a/src/superio/ite/it8772f/superio.c +++ b/src/superio/ite/it8772f/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <console/console.h> #include <pc80/keyboard.h> #include <arch/io.h> diff --git a/src/superio/ite/it8783ef/superio.c b/src/superio/ite/it8783ef/superio.c index feb373f..36651a1 100644 --- a/src/superio/ite/it8783ef/superio.c +++ b/src/superio/ite/it8783ef/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <pc80/keyboard.h> #include <superio/conf_mode.h> #include <superio/ite/common/env_ctrl.h> diff --git a/src/superio/ite/it8786e/superio.c b/src/superio/ite/it8786e/superio.c index 55fff91..df4b3e7 100644 --- a/src/superio/ite/it8786e/superio.c +++ b/src/superio/ite/it8786e/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <pc80/keyboard.h> #include <superio/conf_mode.h> #include <superio/ite/common/env_ctrl.h> diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c index 22d882e..b87feea 100644 --- a/src/superio/nuvoton/common/early_serial.c +++ b/src/superio/nuvoton/common/early_serial.c @@ -22,6 +22,7 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <stdint.h> #include "nuvoton.h"
diff --git a/src/superio/nuvoton/npcd378/superio.c b/src/superio/nuvoton/npcd378/superio.c index b7f98af..949e278 100644 --- a/src/superio/nuvoton/npcd378/superio.c +++ b/src/superio/nuvoton/npcd378/superio.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <option.h> #include <pc80/keyboard.h> #include <superio/conf_mode.h> diff --git a/src/superio/serverengines/pilot/early_serial.c b/src/superio/serverengines/pilot/early_serial.c index e415413..11d6631 100644 --- a/src/superio/serverengines/pilot/early_serial.c +++ b/src/superio/serverengines/pilot/early_serial.c @@ -5,6 +5,8 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> + #include "pilot.h"
/* Pilot uses 0x5A/0xA5 pattern to activate deactivate config access. */ diff --git a/src/superio/smsc/kbc1100/superio.c b/src/superio/smsc/kbc1100/superio.c index 91457a1..1743624 100644 --- a/src/superio/smsc/kbc1100/superio.c +++ b/src/superio/smsc/kbc1100/superio.c @@ -4,6 +4,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <superio/conf_mode.h> #include <pc80/keyboard.h>
diff --git a/src/superio/smsc/lpc47m10x/early_serial.c b/src/superio/smsc/lpc47m10x/early_serial.c index 38a13f5..7a8e18f 100644 --- a/src/superio/smsc/lpc47m10x/early_serial.c +++ b/src/superio/smsc/lpc47m10x/early_serial.c @@ -3,6 +3,7 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <stdint.h> #include "lpc47m10x.h"
diff --git a/src/superio/smsc/lpc47m15x/early_serial.c b/src/superio/smsc/lpc47m15x/early_serial.c index 5921a48..6c78edc 100644 --- a/src/superio/smsc/lpc47m15x/early_serial.c +++ b/src/superio/smsc/lpc47m15x/early_serial.c @@ -5,6 +5,7 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <stdint.h>
#include "lpc47m15x.h" diff --git a/src/superio/smsc/lpc47n217/superio.c b/src/superio/smsc/lpc47n217/superio.c index a716d19..b721f4b 100644 --- a/src/superio/smsc/lpc47n217/superio.c +++ b/src/superio/smsc/lpc47n217/superio.c @@ -5,6 +5,7 @@ #include <arch/io.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <console/console.h> #include <assert.h>
diff --git a/src/superio/smsc/lpc47n227/superio.c b/src/superio/smsc/lpc47n227/superio.c index 376fddb..90a06ff 100644 --- a/src/superio/smsc/lpc47n227/superio.c +++ b/src/superio/smsc/lpc47n227/superio.c @@ -4,6 +4,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <console/console.h> #include <assert.h> #include <pc80/keyboard.h> diff --git a/src/superio/smsc/sch5545/sch5545_early_init.c b/src/superio/smsc/sch5545/sch5545_early_init.c index 4841571..ed4fa53 100644 --- a/src/superio/smsc/sch5545/sch5545_early_init.c +++ b/src/superio/smsc/sch5545/sch5545_early_init.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <device/pnp.h> #include <stdint.h> -#include <device/pnp_def.h> #include <device/pnp_ops.h> #include "sch5545.h"
diff --git a/src/superio/smsc/sch5545/sch5545_emi.c b/src/superio/smsc/sch5545/sch5545_emi.c index 2bb150c..367148a 100644 --- a/src/superio/smsc/sch5545/sch5545_emi.c +++ b/src/superio/smsc/sch5545/sch5545_emi.c @@ -3,7 +3,6 @@ #include <assert.h> #include <arch/io.h> #include <device/pnp.h> -#include <device/pnp_def.h> #include <device/pnp_ops.h> #include <superio/conf_mode.h>
diff --git a/src/superio/smsc/sch5545/superio.c b/src/superio/smsc/sch5545/superio.c index b6e5308..ce8cdd2 100644 --- a/src/superio/smsc/sch5545/superio.c +++ b/src/superio/smsc/sch5545/superio.c @@ -3,6 +3,7 @@ #include <arch/io.h> #include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <superio/conf_mode.h> #include <console/console.h> #include <pc80/keyboard.h> diff --git a/src/superio/winbond/common/early_init.c b/src/superio/winbond/common/early_init.c index 4b9497e..2fa0144 100644 --- a/src/superio/winbond/common/early_init.c +++ b/src/superio/winbond/common/early_init.c @@ -22,6 +22,7 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <stdint.h> #include "winbond.h"
diff --git a/src/superio/winbond/w83627ehg/superio.c b/src/superio/winbond/w83627ehg/superio.c index 7793fa4..8edf0a2 100644 --- a/src/superio/winbond/w83627ehg/superio.c +++ b/src/superio/winbond/w83627ehg/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <superio/conf_mode.h> #include <superio/hwm5_conf.h> #include <console/console.h> diff --git a/src/superio/winbond/w83627hf/superio.c b/src/superio/winbond/w83627hf/superio.c index c6d2f57..1469baf 100644 --- a/src/superio/winbond/w83627hf/superio.c +++ b/src/superio/winbond/w83627hf/superio.c @@ -2,6 +2,7 @@
#include <device/device.h> #include <device/pnp.h> +#include <device/pnp_def.h> #include <superio/conf_mode.h> #include <superio/hwm5_conf.h> #include <console/console.h>