Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30865 )
Change subject: src/nb/intel/sandybridge/pcie.c: remove assert()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30865/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30865/1//COMMIT_MSG@9
PS1, Line 9: Use proper if() statements instead.
Don't rephrase what your commit does. Mention why you are doing it instead.
Also, because I don't understand why.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If097ae6d387de393e45d820b65d60b17026e1805
Gerrit-Change-Number: 30865
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 12 Jan 2019 23:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment