Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Wonkyu Kim, Bernardo Perez Priego, Srinidhi N Kaushik, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50897 )
Change subject: soc/intel/tigerlake: Add CNVi Bluetooth flag at devicetree entry
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50897/comment/5d6efbd3_b9cb37b6
PS1, Line 11: no longer PCI host
Was this dropped at some point? Or it never existed?
Commit Message:
https://review.coreboot.org/c/coreboot/+/50897/comment/17189f81_a94936a3
PS6, Line 11: there is no longer PCI host
: interface for BT.
no longer.. how did that change? Is there a document that captures this?
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50897/comment/82f4f30f_d9f0ca29
PS6, Line 357: CnviBtCore
Instead of adding a separate chip config for this, can we make use of PCH_DEVFN_CNVI_WIFI device to make this decision?
```
dev = pcidev_path_on_root(PCH_DEVFN_CNVI_WIFI);
if (is_dev_enabled(dev)) {
params->CnviMode = 1;
params->CnviBtCore = 1;
}
```
At least at this point, I don't expect to see combinations where CNVi wifi is used with BT disabled. If it is required in the future, we can always add that config at that time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50897
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71c512fe884060e23ee26e7334c575c4c517b78d
Gerrit-Change-Number: 50897
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: AndreX Andraos
andrex.andraos@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 26 Feb 2021 20:41:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment