Attention is currently required from: Angel Pons, Matt DeVillier.
Filip Brozovic has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/85987?usp=email )
Change subject: CFR: add dependencies based on specific option values
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/option/cfr_frontend.h:
https://review.coreboot.org/c/coreboot/+/85987/comment/30e06405_555c81d1?usp... :
PS1, Line 115: .dep_values = ((const uint32_t[]) { __VA_ARGS__ }), \
Does this work? I'm not sure where the array will be stored.
It gets expanded to a compound literal which declares a static array and stores a pointer in dep_values
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85987?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf7965551490969052eb27c207fa524470d4dd6a
Gerrit-Change-Number: 85987
Gerrit-PatchSet: 1
Gerrit-Owner: Filip Brozovic
fbrozovic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 16:05:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com