Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44914 )
Change subject: soc/intel/tigerlake: Add mainboard hook for overriding SoC config
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44914/2/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44914/2/src/soc/intel/tigerlake/fsp...
PS2, Line 84:
: void __weak
nit: we typically do __weak void although I do see both
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44914
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff28e4a29fab5c22c410cdc743d0402134c4ac56
Gerrit-Change-Number: 44914
Gerrit-PatchSet: 2
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 31 Aug 2020 17:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment