Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Paul Menzel, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52197 )
Change subject: soc/amd/cezanne: add downcoring and SMT disable settings to devicetree
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/52197/comment/5569b96b_5a6d1575
PS1, Line 16: uint8_t
Yup, same for picasso too. AGESA sanity checks it BTW.
Felix, did you intend to change this too?
https://review.coreboot.org/c/coreboot/+/52197/comment/b5f41bc1_f2218cf5
PS1, Line 16: disable_smt
i added to the comment on downcore_mode that it's about physical cores; that in combination with the […]
I thought SMT is industry nomenclature for Symmetric MultiThreading aka hyperthreading, but were you asking for that commented too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id03454ed2be242bce9497560c089f75046ed7e32
Gerrit-Change-Number: 52197
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 19 Apr 2021 20:41:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment