Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44476 )
Change subject: ec/kontron/kempld: add option to configure I2C frequency ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44476/13/src/ec/kontron/kempld/kemp... File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/44476/13/src/ec/kontron/kempld/kemp... PS13, Line 231: dev->chip_info;
config_of() is a shorthand to avoid an explicit null-check which is not […]
For me config_of provides a common way to get the config struct pointer of a given device. As an add-on, it makes sure, that we do have access to the struct at all. If everything is well configured, config _is_ accessible and the die() will never be taken. On the other hand, if the pointer to the config-struct could not be obtained, there might be an error in the configuration of the build (not enabled the device while the driver stays enabled). In this case I would prefer to be informed as soon as possible to have a chance to correct it. Nevertheless, I have no strong opinion in favor of any way. So if you feel to change it back, I can deal with it a s well.