Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38007 )
Change subject: sb/amd/cimx,hudson: Use common enable_usbdebug ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38007/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38007/1//COMMIT_MSG@10 PS1, Line 10: got removed from fam14 with fam10 deprecation, this brings it back. maybe `this also brings that back`? When I read the sentence, I already forgot about the summary and was under the impressions that this is all the changes is about.
https://review.coreboot.org/c/coreboot/+/38007/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/enable_usbdebug.c:
https://review.coreboot.org/c/coreboot/+/38007/1/src/southbridge/amd/pi/huds... PS1, Line 35: return PCI_DEV(0, 0x16, 0); The other code is using fn 2, what's going on?