Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45391 )
Change subject: drivers/intel/fsp2_0: ask FSP to allocate APEI BERT memory region
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45391/1/src/drivers/intel/fsp2_0/cb...
File src/drivers/intel/fsp2_0/cbmem.c:
https://review.coreboot.org/c/coreboot/+/45391/1/src/drivers/intel/fsp2_0/cb...
PS1, Line 9: void *tolum_base;
Let's avoid void * arithmetic if we can. Just use uint8_t *?
https://review.coreboot.org/c/coreboot/+/45391/1/src/drivers/intel/fsp2_0/cb...
PS1, Line 14: return tolum_base + cbmem_overhead_size();
Please add a comment why range_entry_end() cannot be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45391
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie72240e4c5fa01fcf937d33678c40f9ca826487a
Gerrit-Change-Number: 45391
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 15:02:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment