Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35803 )
Change subject: mb/google/hatch: Preserve MRC training data across FW update
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35803/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/35803/1/src/mainboard/google/hatch/...
PS1, Line 22: RW_PRESERVE
nit: MRC_CACHE maybe? RW_PRESERVE doesn't have a lot of meaning
I modelled it after octopus here:
https://cs.corp.google.com/chromeos_public/src/third_party/coreboot/src/main...
I don't feel strongly about the name though...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5eb228b1f665a8371982544723dab3dfc40d401
Gerrit-Change-Number: 35803
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Oct 2019 20:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment