Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 97: Code-Review+1
(8 comments)
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 101: register "SataPortsEnable" = "{ Do all SATA ports work?
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 149: subsystemid 0x1043 0x8694 inherit indent this
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 189: blank line can be removed
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 25: #include <soc/intel/skylake/acpi/ipu.asl> I think you can remove this
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 32: you can remove this blank line
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 15: eDP nope? your board doesn't have eDP
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 14: 0x0 Replace all these 0x0 with 0
All of them, please.
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 29: 4, Put this on the next line