Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38268 )
Change subject: intel/{gm45,x4x},i82801{ix|jx}: Move enable_smbus() call
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38268/4/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801jx/early_init.c:
https://review.coreboot.org/c/coreboot/+/38268/4/src/southbridge/intel/i8280...
PS4, Line 84: if (ENV_ROMSTAGE)
Not sure if it matters, but nobody calls i82801jx_early_init() other than x4x/romstage. […]
By keeping this there's some uniformity with the other chipsets, so the argument can go either way. If somebody objects violently with this, they can push a commit to change it :-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc7631abb550b31af722ccf3b69afdc01fdb616e
Gerrit-Change-Number: 38268
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jan 2020 18:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment