Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46296 )
Change subject: soc/intel/alderlake: Enable TME for Alder Lake
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46296/1/src/soc/intel/alderlake/rom...
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/46296/1/src/soc/intel/alderlake/rom...
PS1, Line 159: /* Change TmeEnable UPD value according to INTEL_TME Kconfig */
I think this comment is a biiit redundant, we might as well drop it
(same applies to other comments, but can be done in another patch)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46296
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6992957bd2999a2efbae7b6d9c825c43bd118f72
Gerrit-Change-Number: 46296
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Oct 2020 14:07:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment