Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33640 )
Change subject: superio/nuvoton/nct6791d: Add symbol to select COM port ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/33640/1/src/superio/nuvoton/common/early_ser... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/#/c/33640/1/src/superio/nuvoton/common/early_ser... PS1, Line 73: Route GPIO8 pin group to COM A isn't it the other way around? COM A gets routed to the pins of that GPIO group
https://review.coreboot.org/#/c/33640/1/src/superio/nuvoton/common/early_ser... PS1, Line 74: pnp_write_config(dev, 0x2a, 0x00); hmm, would it be better to only modify the bits corresponding to the serial port pinmux?