Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/block: Add Intel common reset code ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... File src/soc/intel/common/block/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... PS7, Line 35: global_reset Why prefer `global_reset` here over `do_global_reset`? Although I will say, the naming here is getting kinda confusing.