Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48581 )
Change subject: soc/amd/common: Remove SMBus host word accessors ......................................................................
soc/amd/common: Remove SMBus host word accessors
SMBus controller has byte-wide registers. Remove the word accessors.
Change-Id: If396108308bc8303d84458039b9529ecd83276c9 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48581 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 0 insertions(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index 15445ba..134e053 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -244,41 +244,21 @@ return read8(acpimmio_asf + reg); }
-static inline uint16_t asf_read16(uint8_t reg) -{ - return read16(acpimmio_asf + reg); -} - static inline void asf_write8(uint8_t reg, uint8_t value) { write8(acpimmio_asf + reg, value); }
-static inline void asf_write16(uint8_t reg, uint16_t value) -{ - write16(acpimmio_asf + reg, value); -} - static inline uint8_t smbus_read8(uint8_t reg) { return read8(acpimmio_smbus + reg); }
-static inline uint16_t smbus_read16(uint8_t reg) -{ - return read16(acpimmio_smbus + reg); -} - static inline void smbus_write8(uint8_t reg, uint8_t value) { write8(acpimmio_smbus + reg, value); }
-static inline void smbus_write16(uint8_t reg, uint16_t value) -{ - write16(acpimmio_smbus + reg, value); -} - static inline uint8_t iomux_read8(uint8_t reg) { return read8(acpimmio_iomux + reg);