Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 26: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/42079/26/src/soc/intel/tigerlake/fs... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42079/26/src/soc/intel/tigerlake/fs... PS26, Line 391: vboot_developer_mode_enabled())) indented, like: ``` if (CONFIG(EARLY_TCSS) && (vboot_recovery_mode_enabled() || vboot_developer_mode_enabled()))
```
https://review.coreboot.org/c/coreboot/+/42079/26/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/42079/26/src/soc/intel/tigerlake/in... PS26, Line 131: /* Weak mainboard method to setup any mux configuration needed for early tcss operations nit: ``` /* * Weak mainboard method to setup... ``` with the blank `/*` is coreboot's comment style
https://review.coreboot.org/c/coreboot/+/42079/26/src/soc/intel/tigerlake/in... PS26, Line 131: /* Weak mainboard method to setup any mux configuration needed for early tcss operations : * this function ...TCSS operations. This function will...
https://review.coreboot.org/c/coreboot/+/42079/26/src/soc/intel/tigerlake/in... PS26, Line 135: tcss_mux : * struct `struct tcss_mux`