Attention is currently required from: Martin Roth, Mathew King, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51238 )
Change subject: mb/google/guybrush: Enable eSPI VW SCI events
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/guybrush/ec.c:
https://review.coreboot.org/c/coreboot/+/51238/comment/8f8c20b9_d35d1ec8
PS5, Line 14: GEVENT_24
This can only map to one of the following Gevents:
00000: map event source 26 to the input of Event_Status bit 0
00001: map event source 26 to the input of Event_Status bit 1
11111: map event source 26 to the input of Event_Status bit 31
I also filed b/181968650 to clarify how this is supposed to work. If this is a level interrupt, we need to make sure it gets cleared correctly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51238
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12fb7c23718ad2350478b89b321e9f0aa099e53b
Gerrit-Change-Number: 51238
Gerrit-PatchSet: 5
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 05 Mar 2021 17:23:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment