Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34512 )
Change subject: mb/google/octopus: Override VBT selection for Dorp ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34512/4/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/meep/variant.c:
https://review.coreboot.org/c/coreboot/+/34512/4/src/mainboard/google/octopu... PS4, Line 28: case SKU_33_DORP:
'DORP' may be misspelled - perhaps 'DROP'?
no
https://review.coreboot.org/c/coreboot/+/34512/4/src/mainboard/google/octopu... PS4, Line 29: case SKU_34_DORP:
'DORP' may be misspelled - perhaps 'DROP'?
no
https://review.coreboot.org/c/coreboot/+/34512/4/src/mainboard/google/octopu... PS4, Line 30: case SKU_35_DORP:
'DORP' may be misspelled - perhaps 'DROP'?
no
https://review.coreboot.org/c/coreboot/+/34512/4/src/mainboard/google/octopu... PS4, Line 31: case SKU_36_DORP:
'DORP' may be misspelled - perhaps 'DROP'?
no
https://review.coreboot.org/c/coreboot/+/34512/4/src/mainboard/google/octopu... PS4, Line 32: return "vbt_dorp_hdmi.bin";
'dorp' may be misspelled - perhaps 'drop'?
no