Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Raul Rangel.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76888?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/amd/*/include/data_fabric: rename D18F0_MMIO_* to DF_MMIO_*
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/amd/cezanne/include/soc/data_fabric.h:
https://review.coreboot.org/c/coreboot/+/76888/comment/94650b86_3b20a587 :
PS3, Line 9: #define DF_MMIO_BASE0 DF_REG_ID(0, 0x200)
do you want one more tab to align all? I'm fine though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0355838ac1d513ba562fd6fb4672342dd383498
Gerrit-Change-Number: 76888
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 07 Aug 2023 00:40:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment