Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32074 )
Change subject: nb/intel/sandybridge/acpi: Don't use defines for memory ranges ......................................................................
Patch Set 7: Code-Review-1
(9 comments)
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... File src/northbridge/intel/sandybridge/acpi/hostbridge.asl:
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 34: 24 27
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 38: 13 14
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 39: 22 24
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 46: 10 11
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 51: 24 27
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 106: 14 15
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... File src/northbridge/intel/sandybridge/acpi/sandybridge.asl:
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 52: 14 15
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 55: 13 12
https://review.coreboot.org/#/c/32074/7/src/northbridge/intel/sandybridge/ac... PS7, Line 58: DMBR is this correct? seems wrong to me, since it's just the last resource repeated. should this have been EPBR?