build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )
Change subject: mediatek/mt8183: Add display driver ......................................................................
Patch Set 1:
(23 comments)
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... File src/soc/mediatek/mt8183/include/soc/ddp.h:
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 35: u32 disp_ovl0_2l_mout_en; /* 0xF04 */ please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 36: u32 disp_ovl1_2l_mout_en; /* 0xF08 */ please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 37: u32 disp_dither0_mout_en; /* 0xF0C */ please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 39: u32 disp_path0_sel_in; /* 0xF24 */ please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 70: CG_CON0_SMI_COMMON = BIT(0), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 71: CG_CON0_SMI_LARB0 = BIT(1), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 72: CG_CON0_GALS_COMMON0 = BIT(3), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 73: CG_CON0_GALS_COMMON1 = BIT(4), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 77: CG_CON0_DISP_RDMA0 = BIT(23), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 78: CG_CON0_DISP_RDMA1 = BIT(24), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 79: CG_CON0_DISP_WDMA0 = BIT(25), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 80: CG_CON0_DISP_COLOR0 = BIT(26), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 81: CG_CON0_DISP_CCORR0 = BIT(27), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 82: CG_CON0_DISP_AAL0 = BIT(28), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 83: CG_CON0_DISP_GAMMA0 = BIT(29), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 97: CG_CON0_ALL = 0xffffffff please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 113: OVL0_MOUT_EN_RDMA0 = BIT(0), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 114: OVL0_MOUT_EN_OVL0_2L = BIT(4), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 115: OVL0_2L_MOUT_EN_DISP_PATH0 = BIT(0), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 116: OVL1_2L_MOUT_EN_DISP_RDMA1 = BIT(4), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 161: MUTEX_MOD_DISP_GAMMA0| MUTEX_MOD_DISP_DITHER0, need consistent spacing around '|' (ctx:VxW)
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 295: PQ_EN = BIT(0), please, no space before tabs
https://review.coreboot.org/#/c/31478/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 296: PQ_RELAY_MODE = BIT(0), please, no space before tabs